Skip to content

Improve HTMLCollection and friends #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 17, 2021
Merged

Improve HTMLCollection and friends #599

merged 9 commits into from
Oct 17, 2021

Conversation

armanbilge
Copy link
Member

Supersedes #593, just fixes the merge and makes HTMLCollection covariant in E. My git-fu wasn't good enough to figure out a merge from a master to a master 😕

@armanbilge armanbilge requested a review from japgolly October 17, 2021 09:11
@japgolly japgolly merged commit 8a2d8f6 into master Oct 17, 2021
@japgolly japgolly deleted the topic/html-collection branch October 17, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japgolly japgolly japgolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armanbilge @japgolly @ghostbuster91